ActionMenu: Fix keyboard navigation for ActionMenu inside Overlay #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 062ff87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
changed the title
siddharthkp
requested review from
a team,
mperrotti and
colebemis
and removed request for
mperrotti
colebemis
approved these changes
Aug 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for reviewer:
I had removed focus trap in #2024 as redundant, because we handle keyboard interactions already. released in v35.6.0
I found a use case where focus trap can't be removed - when ActionMenu is inside a focus trap (like AnchoredOverlay), keyboard navigation of ActionMenu would get hijacked by the parent focus trap. Re-introducing focus trap solves this issue.
Is this change safe?
Tested this change in memex (https://github.com/github/memex/pull/11620), one failed test (expected, caused by bringing back focus trap 👍).
Are there any edge cases?
Known issue: Pressing Tab on an open menu closes the menu and put the focus back on the anchor instead of the next element because it "returns" to the parent focus trap. I didn't find a way to communicate to the parent focus trap to move focus to the next tabbable element :(
Unrelated change
Consumer tests are failing on this PR, any ideas?
Details:
Fixes keyboard navigation for the menu in memex project settings (private project)
before:
before-2266.mov
after:
after-2266.mov
Accessibility
There is overlap between keyboard navigation of Overlay's focus trap and Menu's focus trap inside it, not sure what the ideal behavior is.
Asked on the accessibility channel (private github slack), For overlays with forms, we should use Tabs bindings not ArrowKeys (memex already does that, so we're good!)
video
tabs-focus-trap.mov
Long term: we should look in to the defaults and recommended component for overlays. AnchoredOverlay is pretty low level, we need to improve Dialog (with focus trap with Tab bindings) and make that the recommended component.
scenarios & video for a11y issues
Default scenario: AnchoredOverlay's focus trap has bindings for ArrowKeys (not Tabs), (see story for running example)
https://github.slack.com/archives/C0FSWLQ0Y/p1661507974126029
Customised scenario in memex: AnchoredOverlay's focus trap has bindings for Tabs,
tabs-focus-trap.mov